feat: using ProposalPart's ProposalCommitment for validation#3012
Merged
Conversation
t00ts
reviewed
Sep 19, 2025
Contributor
t00ts
left a comment
t00ts
left a comment
There was a problem hiding this comment.
LGTM % some nits.
Last file (validator.rs) has a bunch of TODOs, I suppose that's expected (?) as of now.
vbar
force-pushed
the
vbar/proposal-commitment-part
branch
from
6dd7e20 to
3971728
Compare
t00ts
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added ProposalCommitment to the empty proposal (which is being flaky, and fixes to it will probably require changes to this PR as well).
Fixes #3009 .